Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] regex restriction on GCP Batch custom label values #7351

Closed
bchen4 opened this issue Jan 4, 2024 · 5 comments
Closed

[BUG] regex restriction on GCP Batch custom label values #7351

bchen4 opened this issue Jan 4, 2024 · 5 comments

Comments

@bchen4
Copy link

bchen4 commented Jan 4, 2024

I was trying to label all GCP batch resources using -o in the CLI. (according to this doc and this doc )
My content of options.json is

{"google_labels":{"workflow-run-execution-id":"97fed6c4-6442-4efe-9e73-7b3592a33480"}} 

and my command is java -Dconfig.file=config -jar /app/cromwell.jar run wf.wdl -i input.json -o options.json

The error I am getting:
Screen Shot 2024-01-04 at 9 58 25 AM

After adding string prefix to my own uuid as label value, the error was gone and my workflow ran smoothly. However, I do need to pass in the uuid so downstream analysis pipeline can still work.

Related code reporting error is here and error is produce here and this is the regex definition

I am wondering can the code be updated to only check the key of a label so it aligns with GCP which does not have this restriction on label values? Or use another regex "[a-z0-9]([-a-z0-9]*[a-z0-9])?" for label value check?

Cromwell version: I built develop container, and the tag is 87-ee2b10f-SNAP.
Backend: GCP Batch.

Please let me know if this could be something you guys would accept before I put in PR. Thanks.

@bchen4 bchen4 changed the title [BUG] regex restriction on GCP Batch labels [BUG] regex restriction on GCP Batch custom label values Jan 4, 2024
@dspeck1
Copy link
Collaborator

dspeck1 commented Jan 4, 2024

Looks fine to PR. Google Cloud Batch accepts the label starting with a number. Had you run this on PAPv2 previously?

@bchen4
Copy link
Author

bchen4 commented Jan 4, 2024

Looks fine to PR. Google Cloud Batch accepts the label starting with a number. Had you run this on PAPv2 previously?

Nope, just Batch. I will submit something soon.

@bchen4
Copy link
Author

bchen4 commented Jan 5, 2024

@dspeck1 here is the PR #7353

@AlexITC
Copy link
Collaborator

AlexITC commented Apr 24, 2024

Given that #7355 was merged, is this issue resolved?

@aednichols
Copy link
Contributor

PR merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants