-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] regex restriction on GCP Batch custom label values #7351
Labels
Comments
bchen4
changed the title
[BUG] regex restriction on GCP Batch labels
[BUG] regex restriction on GCP Batch custom label values
Jan 4, 2024
Looks fine to PR. Google Cloud Batch accepts the label starting with a number. Had you run this on PAPv2 previously? |
Nope, just Batch. I will submit something soon. |
Given that #7355 was merged, is this issue resolved? |
PR merged, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was trying to label all GCP batch resources using
-o
in the CLI. (according to this doc and this doc )My content of options.json is
and my command is
java -Dconfig.file=config -jar /app/cromwell.jar run wf.wdl -i input.json -o options.json
The error I am getting:
After adding string prefix to my own uuid as label value, the error was gone and my workflow ran smoothly. However, I do need to pass in the uuid so downstream analysis pipeline can still work.
Related code reporting error is here and error is produce here and this is the regex definition
I am wondering can the code be updated to only check the key of a label so it aligns with GCP which does not have this restriction on label values? Or use another regex
"[a-z0-9]([-a-z0-9]*[a-z0-9])?"
for label value check?Cromwell version: I built develop container, and the tag is
87-ee2b10f-SNAP
.Backend: GCP Batch.
Please let me know if this could be something you guys would accept before I put in PR. Thanks.
The text was updated successfully, but these errors were encountered: