WX-1420 Fix GCP Batch label regex restriction #7353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
approved these changes
Jan 5, 2024
aednichols
changed the title
THWiseman
approved these changes
Jan 8, 2024
|
Hi @bchen4, thanks for the PR. I created a clone inside the repo to run unit tests: #7353 The tests didn't compile at first which I fixed, but now they are failing and I don't actually know which is wrong, the assertion or the code under test. I added you as a writer to this repo so you should be able to push to my |
|
Merged as #7355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7351