Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-1420 Fix GCP Batch label regex restriction #7355

Merged
merged 7 commits into from
Jan 11, 2024
Merged

WX-1420 Fix GCP Batch label regex restriction #7355

merged 7 commits into from
Jan 11, 2024

Conversation

aednichols
Copy link
Contributor

Clone of #7353 to run tests

@aednichols aednichols requested a review from a team as a code owner January 9, 2024 22:47
@aednichols
Copy link
Contributor Author

scalafmt

@bchen4
Copy link

bchen4 commented Jan 11, 2024

scalafmt

Fixed that by removing the test case. Now unit tests passed but the codecov failed.

@aednichols
Copy link
Contributor Author

ah, nice

FWIW scalafmt is a keyword that when commented, runs the tool automatically

@aednichols
Copy link
Contributor Author

Codecov isn't a mandatory check, we just don't have a way to tell Github to display the number without a red or green check.

@bchen4
Copy link

bchen4 commented Jan 11, 2024

Codecov isn't a mandatory check, we just don't have a way to tell Github to display the number without a red or green check.

Cool, so pending one more approval and then merge? (also finger cross on other tests)

@aednichols
Copy link
Contributor Author

Since none of the functional code changed from #7353 which has two approvals, I will wait for tests to pass and admin-merge.

@aednichols aednichols merged commit ec1f3ac into develop Jan 11, 2024
34 checks passed
@aednichols
Copy link
Contributor Author

Thanks for your contribution!

@aednichols aednichols deleted the aen_wx_1420 branch January 11, 2024 21:45
@aednichols aednichols mentioned this pull request Jan 11, 2024
Closed
salonishah11 pushed a commit that referenced this pull request Feb 15, 2024
@aednichols @beichen1024
@jgainerdewar @salonishah11
WX-1420 Fix GCP Batch label regex restriction (#7355)
1043c37 
Co-authored-by: Beibei Chen <beibei@formbio.com>
Co-authored-by: Janet Gainer-Dewar <jdewar@broadinstitute.org>
@AlexITC AlexITC mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aednichols @bchen4 @jgainerdewar @beichen1024