Allow struct imports #3431
Merged
Allow struct imports #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjllanwarne
force-pushed
the
cjl_import_structs
branch
from
235ec68
to
c58a92d
Compare
cjllanwarne
changed the base branch from
cjl_draft3_taskless_engine_functions
to
develop
1 task
Horneth
approved these changes
Mar 20, 2018
ghost
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Involved a little bit of shuffling of the LanguageFactory interface, and there's a lot of noise caused by renaming the
ImportResolverfrom draft 2 (so that I could use the name myself for a more general Kleisli version).There's an open question of how exactly to define where to look for
"structs.wdl"for example (right now it's the language but maybe it should be the engine?)