This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix for https://github.com/broadinstitute/foghorn/issues/149 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hold off on merging this fix until #384 is merged, as it conflicts with the changes in that branch. |
|
Now that #384 has been merged, this can be rebased on top of those changes (will probably get merge conflicts). |
|
I would like to see a test which demonstrates the fix as well. Thanks for looking into this btw! |
|
What is the status of this? |
kgururaj
force-pushed
the
intel_multi_iterator_fix
branch
from
92e28af
to
6ce9443
Compare
|
Added a test case for empty VCF traversal using MVI. The test crashes without the fix. |
|
👍 looks good to me -- but @jmthibault79 should have a look too |
|
Looks good but I would also like a copy of the test for MultipleVariantIterator (current one tests ReferenceBlockSplittingVariantIterator). OK to rebase and merge yourself when that is added. |
of the inputs is a blank VCF Added a simple test case for empty VCF traversal using MultipleVariantIterator
kgururaj
force-pushed
the
intel_multi_iterator_fix
branch
from
6ce9443
to
5b0e0f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/broadinstitute/foghorn/issues/149
Check for missing variant in MultipleVariantIterator - important if one of the inputs is a blank VCF
TODO: Are there other places this check needs to be done?