add cram to testresources #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akiezun 👍 Lets wait for tests though just in case something horrible happens. |
|
We might want to reconsider using a .crai file as an index (see samtools/htsjdk#531 and samtools/hts-specs#146). At this point, I would use a .bai (generate the .cram using GATK to get the .bai). It would also be interesting to know if the HC perf is any different using the .bai generated this way. |
|
Someone didn't squash and now owes everyone beer :) |
|
hmm, maybe github does - the button said "confirm squash and merge" |
|
You're right, github did it for you -- the wonders of the modern age! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding cram version of our main test bam
@lbergelson, ok?