Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log4j logging which was broken due to multiple copies being prese… #3652

Merged
merged 1 commit into from Oct 5, 2017

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Oct 3, 2017

…nt on the classpath. Fixes #2622.

@tomwhite tomwhite self-assigned this Oct 3, 2017
@codecov-io
Copy link

codecov-io commented Oct 3, 2017

Codecov Report

Merging #3652 into master will increase coverage by 0.012%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #3652       +/-   ##
===============================================
+ Coverage     79.384%   79.396%   +0.012%     
- Complexity     17292     17324       +32     
===============================================
  Files           1140      1140               
  Lines          62494     62575       +81     
  Branches        9489      9494        +5     
===============================================
+ Hits           49610     49682       +72     
- Misses          9108      9112        +4     
- Partials        3776      3781        +5
Impacted Files Coverage Δ Complexity Δ
...e/hellbender/engine/spark/SparkContextFactory.java 71.233% <0%> (-2.74%) 11% <0%> (ø)
...der/tools/walkers/contamination/PileupSummary.java 90.196% <0%> (-1.232%) 24% <0%> (+10%)
...ools/walkers/contamination/GetPileupSummaries.java 88.235% <0%> (-0.954%) 22% <0%> (+9%)
...er/tools/spark/sv/discovery/AlignmentInterval.java 89.212% <0%> (ø) 64% <0%> (ø) ⬇️
.../walkers/contamination/CalculateContamination.java 89.552% <0%> (+0.663%) 37% <0%> (+13%) ⬆️
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 79.87% <0%> (+1.299%) 39% <0%> (ø) ⬇️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we may want to figure out a more permanent solution to this at some point or it's going to keep sneaking back in

@lbergelson lbergelson merged commit daa0cd1 into master Oct 5, 2017
@lbergelson lbergelson deleted the tw_fix_log4j_error branch October 5, 2017 15:15
@lbergelson
Copy link
Member

@tomwhite Thank you!

@lbergelson lbergelson mentioned this pull request Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants