New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating a new tool to compare interval lists #3702
Conversation
final GenomeLocParser genomeLocParser = new GenomeLocParser(samSequenceDictionary); | ||
final GenomeLocSortedSet firstIntervals = getGenomeLocs(genomeLocParser, firstIntervalFile); | ||
final GenomeLocSortedSet secondIntervals = getGenomeLocs(genomeLocParser, secondIntervalFile); | ||
final String result = IntervalUtils.equateIntervals(firstIntervals.toList(), secondIntervals.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the interval files are both empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be fine - added some tests to this effect and they behave as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some comments, but looks reasonable. I had one quick question about the file comparison.
Codecov Report
@@ Coverage Diff @@
## master #3702 +/- ##
============================================
+ Coverage 87.08% 87.09% +<.01%
- Complexity 31522 31531 +9
============================================
Files 1930 1932 +2
Lines 145236 145271 +35
Branches 16096 16099 +3
============================================
+ Hits 126480 126519 +39
+ Misses 12903 12900 -3
+ Partials 5853 5852 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
99ede46
to
8f85021
Compare
adding a very simple tool to compare two interval list files