Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update htsjdk to 2.23.0 #6702

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Update htsjdk to 2.23.0 #6702

merged 1 commit into from
Jul 17, 2020

Conversation

lbergelson
Copy link
Member

@lbergelson
Update htsjdk to 2.23.0
47b628c 
* Updating htsjdk 2.22.0 -> 2.23.0
* This fixes #6664
@lbergelson lbergelson requested a review from cmnbroad July 13, 2020 22:03
@droazen droazen self-requested a review July 17, 2020 17:47
@droazen droazen assigned droazen and unassigned cmnbroad Jul 17, 2020
droazen
droazen approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

build.gradle
@@ -61,7 +61,7 @@ repositories {
mavenLocal()
}

final htsjdkVersion = System.getProperty('htsjdk.version','2.22.0')
final htsjdkVersion = System.getProperty('htsjdk.version','2.23.0')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test somewhere showing that the MergeVcfs issue is resolved?

@droazen droazen assigned lbergelson and unassigned droazen Jul 17, 2020
@lbergelson
Copy link
Member Author

@droazen There are tests for the file handling in htsjdk but not a specific one for MergeVcfs.

@lbergelson lbergelson merged commit 1836ab0 into master Jul 17, 2020
@lbergelson lbergelson deleted the lb_update_htsjdk branch July 17, 2020 17:52
mwalker174 pushed a commit that referenced this pull request Nov 3, 2020
@lbergelson @mwalker174
Update htsjdk to 2.23.0 (#6702)
2dc0fb6 
* Updating htsjdk 2.22.0 -> 2.23.0
* This fixes #6664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droazen droazen droazen approved these changes

@cmnbroad cmnbroad Awaiting requested review from cmnbroad

Assignees

@lbergelson lbergelson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MergeVcfs] Unexpected behavior with path containing whitespace
3 participants
@lbergelson @droazen @cmnbroad