Switch GATK to the Apache 2.0 license #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbergelson please review |
jonn-smith
requested review from
jonn-smith
and removed request for
lbergelson
jonn-smith
previously requested changes
Feb 17, 2021
Co-authored-by: Jonn Smith <jonn-smith@users.noreply.github.com>
Co-authored-by: Jonn Smith <jonn-smith@users.noreply.github.com>
droazen
force-pushed
the
dr_switch_to_apache_license
branch
from
7f53928
to
0b65f12
Compare
jamesemery
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
I just did my own pass for any remaining License language that I could find that could cause problems with the new language. Besides bits that get pulled in by our build/dependencies I see a few python files with old license agreements CreateCosmicFusionGene.tsv, CreateCosmicGene.tsv, and GenericTsvReader.py. We should probably ask about whether those can be done away with. They look like old oncotator code perhaps?
| @@ -8,15 +8,6 @@ | |||
| import org.broadinstitute.hellbender.tools.walkers.varianteval.util.Analysis; | |||
| import org.broadinstitute.hellbender.tools.walkers.varianteval.util.DataPoint; | |||
|
|
|||
| /** | |||
| * The Broad Institute | |||
There was a problem hiding this comment.
I just did a check and these 3 files seem to be the last vestiges of old license code in the headers of any of our source files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.