update build to be more modern #12
Conversation
* updating class file location due to gradle changes
* moving from maven -> maven-publish plugin * make build.gradle more modern and cleaner * fix artifactory link to new broad artifactory * using gradle properties for artifactory password instead of environment variables
updating gatk-native-library version to 1.0.0
|
@samuelklee In order to fix the log issue I've updated the gradle build. Could you do a review? |
| maven { | ||
| credentials { | ||
| username = isRelease ? project.findProperty("sonatypeUsername") : project.findProperty("artifactoryUsername") | ||
| password = isRelease ? project.findProperty("sonatypePassword") : project.findProperty("artifactoryPassword") |
There was a problem hiding this comment.
what will happen if you don't set either of these? can we get a nice error message?
There was a problem hiding this comment.
if it's not set and you don't try to publish, no problem
if it's not set and you do try to publish, you get a not very helpful error. I haven't come up with a good way to throw a more useful exception because of the way that configuration / execution works.
I want to be able to run something at the time the task is configured but only if the task is in the execution graph but I'm not sure how to do it...
|
Thanks, @lbergelson! I'm probably not qualified to do a review, so glad @droazen has it covered. |
as part of preparing to release a new version with fixes I updated the gradle build