New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the shadowJar multi-release. #1749
Conversation
@@ -141,7 +141,9 @@ tasks.withType(Jar){ | |||
attributes 'Main-Class': 'picard.cmdline.PicardCommandLine', | |||
'Implementation-Title': 'Picard', | |||
'Implementation-Vendor': 'Broad Institute', | |||
'Implementation-Version': version | |||
'htsjdk-Version': htsjdkVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary for the fix but seems like a fine addition...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was inspired by your example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
We could add the following test to the script section of build.gradle. It doesn't add very much time to the build.
|
@gbggrant I think we have to merge my other pr that fixes that doc problem on java 11 before running the complete |
Sorry, try replacing |
Added a test to handle the version 11 incompatibility we encountered
30ea4c4
to
2654675
Compare
Description
This PR changes the jar packaging to be multi-release. This addresses the issues surfaced with the upgrade to gkl 0.8.8
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests