Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-1941. Handle Out of Range Values in GTC metrics #1777

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

gbggrant
Copy link
Contributor

@gbggrant gbggrant commented Feb 17, 2022

Description

https://broadinstitute.atlassian.net/browse/GL-1941

In GtcToVcf, set infinite values to missing ('.') in the VCF.
In VcfToAdpc, if value is a '?' (which was what had been encoded for infinite) treat as missing.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

In VcfToAdpc, if value is a '?' (which was what had been encoded for infinite) treat as missing.
@gbggrant gbggrant changed the title Handle Out of Range Values in Gtc metrics GL-1941. Handle Out of Range Values in GTC metrics Feb 17, 2022
@gbggrant gbggrant merged commit a03ed41 into master Feb 17, 2022
@gbggrant gbggrant deleted the gg_HandleInfinitesInGtcToVcf branch February 17, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants