Fix gradle 8 publishing issue #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes:
|
kshakir
commented
Jul 28, 2023
There was a problem hiding this comment.
Does anyone have a preference for how to list dependencies?
I noticed in the GATK that it seems to be more like "Option a)" below.
Comment on lines
-102
to
-117
| distZip { | ||
| dependsOn 'currentJar' | ||
| } | ||
|
|
||
| distTar { | ||
| dependsOn 'currentJar' | ||
| } | ||
|
|
||
| startScripts { | ||
| dependsOn 'currentJar' | ||
| } | ||
|
|
||
| startShadowScripts { | ||
| dependsOn 'currentJar' | ||
| } | ||
|
|
There was a problem hiding this comment.
Option a) Multiple independent dependencies
Comment on lines
+404
to
+411
| // For Gradle 8 explicitly add 'currentJar' as a dependency of the following tasks. | ||
| // For more information, please refer to | ||
| // https://docs.gradle.org/8.2.1/userguide/validation_problems.html#implicit_dependency in the Gradle documentation. | ||
| ['distZip', 'distTar', 'startScripts', 'startShadowScripts', 'generateMetadataFileForPicardPublication'].each { | ||
| tasks.named(it).configure { | ||
| dependsOn 'currentJar' | ||
| } | ||
| } |
There was a problem hiding this comment.
Option b) Use a loop to put them all in one place
There was a problem hiding this comment.
It feels like there is probably a more idiomatic way to do this by adding it to the java component or something like that, but I don't know how and it doesn't seem worthwhile to figure it. This is way better than a zillion individual closures adding it.
lbergelson
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
gradle publishafter changes in #1903Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests