Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for REFERENCE_SEQUENCE to avoid NPE in CollectSequencingA… #639

Merged

Conversation

tfenne
Copy link
Collaborator

@tfenne tfenne commented Aug 26, 2016

…rtifactMetrics

@tfenne
Copy link
Collaborator Author

tfenne commented Aug 26, 2016

@yfarjoun This has been driving me crazy! Because it inherits REFERENCE_SEQUENCE from a parent class, and it's optional up there, CSA doesn't give an error message if it's null, it just NPEs. Trivial change to add a check for it and produce a nicer error message.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 69.265% when pulling 82ade38 on tfenne:tf_artifact_metrics_check_for_ref into 49a8cbf on broadinstitute:master.

@yfarjoun
Copy link
Contributor

👍

@nh13 nh13 assigned tfenne and unassigned nh13 and yfarjoun Aug 28, 2016
@nh13
Copy link
Collaborator

nh13 commented Aug 28, 2016

@yfarjoun I think I was assigned this in error.

@yfarjoun
Copy link
Contributor

Oops. Thanks.

On Aug 28, 2016 11:36 AM, "Nils Homer" notifications@github.com wrote:

@yfarjoun https://github.com/yfarjoun I think I was assigned this in
error.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#639 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACnk0iCDjguhKzjeueS5Z0-mW9n1hMARks5qkar3gaJpZM4JuAZL
.

@tfenne tfenne merged commit bd88099 into broadinstitute:master Aug 29, 2016
@tfenne tfenne deleted the tf_artifact_metrics_check_for_ref branch August 29, 2016 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants