Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FilterVcf to filter "sites only" VCFs #962

Merged
merged 4 commits into from Dec 15, 2017

Conversation

yfarjoun
Copy link
Contributor

Description

Currently, FilterVcf will filter entirely a sites-only vcf since "all" the genotypes are filtered (as there are no genotypes) and when a sites has all the genotypes filtered it filters out the site...This modification changes behavior so that a sites only VCF will not be filtered due to "all" its (non-existent) genotypes.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@coveralls
Copy link

coveralls commented Oct 22, 2017

Coverage Status

Coverage remained the same at 77.055% when pulling c8875e2 on yf_fix_vcf_filter_for_sites_only_vcf into 3904528 on master.

Copy link
Contributor

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nh13
Copy link
Collaborator

nh13 commented Dec 13, 2017

@yfarjoun I'd suggest @tfenne take a look since he wrote that line, and also since it isn't backwards compatible!

@yfarjoun
Copy link
Contributor Author

ok. I'll wait to hear from him! thanks for the heads-up!

@tfenne
Copy link
Collaborator

tfenne commented Dec 13, 2017

Thanks for the heads up @nh13. I think the change is fine. My goal was to enable filtering of sites where the site-level filters pass, but all the genotypes got filtered out. I think this still does the same thing so long as there are samples with non-hom-ref genotype present in the file.

@yfarjoun yfarjoun merged commit d9c9b18 into master Dec 15, 2017
@yfarjoun yfarjoun deleted the yf_fix_vcf_filter_for_sites_only_vcf branch December 15, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants