-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support Vue 2|3, refactoring code #166
base: master
Are you sure you want to change the base?
Conversation
I also updated the README |
Nice job! Really good work 👍 |
I think this all makes sense to me, great work 👍 |
Thank you! Write what you need, I'm ready. I would love to be on the list of collaborators) |
Hi @BrockReece, do you think we can have this merged some time soonish? |
I don't think it's worth keeping the old syntax with filters. Even the Vue developers don't recommend doing this either.
I propose a solution that contains support for two versions of Vue, which also passes all the tests you wrote (only, I changed the main moment prototype, it now does not contain the $ symbol).