Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Vue 2|3, refactoring code #166

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rah-emil
Copy link

I don't think it's worth keeping the old syntax with filters. Even the Vue developers don't recommend doing this either.

I propose a solution that contains support for two versions of Vue, which also passes all the tests you wrote (only, I changed the main moment prototype, it now does not contain the $ symbol).

@rah-emil
Copy link
Author

I also updated the README

@AndyKuhorenko
Copy link

Nice job! Really good work 👍

@rah-emil
Copy link
Author

rah-emil commented May 12, 2022

Commit Explanations: 0ddf4ef
78875a7
6d0f2d0

I need this plugin for a project on Vue 3, and there is no time to wait for the merge. I posted my version to myself, but made a revert of these changes for merging with you.😇

@BrockReece
Copy link
Collaborator

I think this all makes sense to me, great work 👍
I think it would be wise to give this package a major package bump when we merge this in, to cover for the breaking changes.

@rah-emil
Copy link
Author

I think this all makes sense to me, great work 👍 I think it would be wise to give this package a major package bump when we merge this in, to cover for the breaking changes.

Thank you! Write what you need, I'm ready. I would love to be on the list of collaborators)

@hluz
Copy link

hluz commented Dec 28, 2023

Hi @BrockReece, do you think we can have this merged some time soonish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants