Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases max allowed windstress #16

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Oct 4, 2022

Closes #15

This would be a simple solution to the problem outlined in #15. It would be nice to change this here (upstream of aerobulk-python) to avoid diverging results between the two packages.

@jbusecke
Copy link
Contributor Author

Quick ping here. Do you think we could merge this (or remove the limit completely as suggested in #15)? We are currently building aerobulk-python from this PR branch (xgcm/aerobulk-python#51) and it would be a lot cleaner going forward (if we want to implement more changes) if we could merge this and repoint to the main of aerobulk.
Thanks and happy holidays!

@brodeau brodeau merged commit 2d0dd17 into brodeau:master Jan 2, 2023
@brodeau
Copy link
Owner

brodeau commented Jan 2, 2023

Done! Sorry for the latency.
Cheers, /laurent

@jbusecke
Copy link
Contributor Author

jbusecke commented Jan 2, 2023

Thanks! And a happy New Year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about value of ref_tau_max
2 participants