Patches for v101

[csagan5]

The first half of the patches for v101.

[uazo]

if it can help you uazo/bromite-buildtools#12
I have not finished yet

[csagan5]

if it can help you uazo/bromite-buildtools#12

Yes, I will use your version of the breaking patches you contributed (Experimental user scripts, Logcat UI etc) and check the differences.

About the JIT patch JIT-site-settings.patch, is the author correct? I see it changed between fgei and hardenedfuchsiaoswhen, do you have the original patch that was used? Instead if you have written this yourself I will change the author.

From #1752 (comment):

theoretically I would like you to take a look at https://github.com/uazo/bromite/tree/master-v100/build/patches/contrib if it is understandable without explanation (but which I will do to you soon anyway)

Are there still patches you would like to submit? I can give a look: are they all still valid?

[csagan5]

Note: I have merged the incognito patches and assigned authorship to you, there are some changes from me and original author but mostly it's your work now.

[uazo]

About the JIT patch JIT-site-settings.patch, is the author correct?

I started from this: https://github.com/GrapheneOS/Vanadium/pull/165/files

Are there still patches you would like to submit?

I would have waited for the 101, so as not to overload yourself.

if you agree on these I would do a separate pull:

1. Add-history-support-in-incognito-mode-addon.patch
   we have to evaluate it together, because it is suitable for always incognito (delete a local track I added with history support) but also for normal to minimize the problem of using large userscripts (remember?).
2. Content-settings-infrastructure.patch
   I would need to do much less work when we add a new site setting (Add-site-settings-for-webgl.patch and the future patch for webrtc).
   the patch for webgl and Multiple-fingerprinting-mitigations-addon.patch are to be reviewed, I still left useless logs and comments because I have yet to answer what you were asking me
3. fix-Add-option-to-force-tablet-UI.patch
   we also have to evaluate this together because it seems strange to me that it is not needed ...
4. Remove-some-trace-on-disk.patch
   this is sketchy, but even as it is, it completely eliminates all useless traces for the always incognito

these instead if you want you can also bring them immediately:

1. Add-more-private-google-search-engine.patch
   I know you disagree with adding more, but you can use it to simplify the current search engine patch
2. Disable-DICE-MIRROR-gaia-mode.patch and Fix-StartupTabPreloader-crash.patch
   it does not change anything in bromite but removes crashes that appears only in debug

Remove-HashAffiliationFetcher.patch is useless for bromite.
while this I have not yet understood if the code goes - really - from there

[csagan5]

About the JIT patch JIT-site-settings.patch, is the author correct?

I started from this: https://github.com/GrapheneOS/Vanadium/pull/165/files

Ok, then I will keep current author.

Are there still patches you would like to submit?

I would have waited for the 101, so as not to overload yourself.

This is not a problem.

1. Add-history-support-in-incognito-mode-addon.patch
   we have to evaluate it together, because it is suitable for always incognito (delete a local track I added with history support) but also for normal to minimize the problem of using large userscripts (remember?).
   2. Content-settings-infrastructure.patch
   I would need to do much less work when we add a new site setting (Add-site-settings-for-webgl.patch and the future patch for webrtc).
   the patch for webgl and Multiple-fingerprinting-mitigations-addon.patch are to be reviewed, I still left useless logs and comments because I have yet to answer what you were asking me

Please open the PRs otherwise there is no review in progress. There is also this to address.

3. fix-Add-option-to-force-tablet-UI.patch
we also have to evaluate this together because it seems strange to me that it is not needed ...

What is the bug and how to reproduce it in Bromite?

4. Remove-some-trace-on-disk.patch
this is sketchy, but even as it is, it completely eliminates all useless traces for the always incognito

Aren't those save-to-file operations needed for normal browsing?

1. Add-more-private-google-search-engine.patch
   I know you disagree with adding more, but you can use it to simplify the current search engine patch

I will merge this to the existing patch for googleen.

2. Disable-DICE-MIRROR-gaia-mode.patch

I will merge this to the signin patch.

2. Fix-StartupTabPreloader-crash.patch
it does not change anything in bromite but removes crashes that appears only in debug

I will merge this to Disable-various-metrics.patch

while this I have not yet understood if the code goes - really - from there

Some logging might shed light on this?

[uazo]

Please open the PRs otherwise there is no review in progress. There is also #1991 (comment) to address.

Sure.

What is the bug and how to reproduce it in Bromite?

the weird thing is that the bug is that it doesn't compile me without!
the error is dependency problem with gn.
I still don't understand well, but I think we use different version of something (compiler, gn, I don't know), though i still don't understand if that's true

Aren't those save-to-file operations needed for normal browsing?

is why I haven't proposed it to you yet, I don't know for now.
I checked only regarding command_storage_backend: I think it's a bug of the (relatively new) desktop implementation which has not been removed in android but, in my opinion, it should because it's useless and, above all, active in incognito mode.

Some logging might shed light on this?

I did, but I don't understand via html / javascript how to get it going from there. But I haven't actually checked the test cases yet

[csagan5]

What is the bug and how to reproduce it in Bromite?

the weird thing is that the bug is that it doesn't compile me without! the error is dependency problem with gn. I still don't understand well, but I think we use different version of something (compiler, gn, I don't know), though i still don't understand if that's true

It could also be a problem of a pre-built file; what should I delete from the built files to test this possibility?

All the tools should be the same because we use the same DEPS; what OS do you use for the builds? I use one of the officially-supported.

[uazo]

It could also be a problem of a pre-built file; what should I delete from the built files to test this possibility?

I don't know, unfortunately.

what OS do you use for the builds?

the server is Ubuntu 20.04.4 LTS
this is the docker image and the script that prepares chromium

[csagan5]

what OS do you use for the builds?

the server is Ubuntu 20.04.4 LTS this is the docker image and the script that prepares chromium

It is a supported version, it should work.