add better error message for invalid types (Fixes #59)

brooklynDev · Jul 3, 2015 · e2da6e9 · e2da6e9
1 parent 51a15ba
commit e2da6e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/airborne/request_expectations.rb b/lib/airborne/request_expectations.rb
@@ -171,6 +171,7 @@ def is_nil_optional_hash?(expectations, hash)
     def expect_type(expected_type, value_class, prop_name = nil)
       insert = prop_name.nil? ? "" : "#{prop_name} to be of type"
       msg = "Expected #{insert} #{expected_type}\n got #{value_class} instead"
+      raise ExpectationError, "Expected type #{expected_type}\nis an invalid type" if @mapper[expected_type].nil?
       expect(@mapper[expected_type].include?(value_class)).to eq(true), msg
     end
 

diff --git a/spec/airborne/expectations/expect_json_types_spec.rb b/spec/airborne/expectations/expect_json_types_spec.rb
@@ -50,4 +50,10 @@
     expect_json_types({name: :string, age: :int, address: :null})
   end
 
+  it 'Should throw bad type error' do
+    mock_get('simple_get')
+    get '/simple_get'
+    expect { expect_json_types(name: :foo) }.to raise_error(Airborne::ExpectationError, "Expected type foo\nis an invalid type")
+  end
+
 end