Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copyResource and copytemplate usable by all entity drivers #528

Merged
merged 2 commits into from
Feb 13, 2013

Conversation

grkvlt
Copy link
Member

@grkvlt grkvlt commented Feb 8, 2013

No description provided.

@buildhive
Copy link

Brooklyn Central » brooklyn #60 SUCCESS
This pull request looks good
(what's this?)

result = getMachine().execCommands("download",
ImmutableList.of(
CommonCommands.INSTALL_CURL,
String.format("curl --silent --insecure %s -o %s", resource, dest)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also want -f in curl command. Otherwise a 404 that returns a html page about it is considered a success.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@aledsage
Copy link
Member

aledsage commented Feb 9, 2013

Definitely useful stuff here. But I'm not sure about adding all this stuff directly to AbstractSoftwareProcessDriver.java and AbstractSoftwareProcessSshDriver.java

@grkvlt
Copy link
Member Author

grkvlt commented Feb 9, 2013

Where else could mechanisms to copy runtime files go, though? I think the use cases are quite clear. Actually, I'd like to add a config key to all SoftwareProcess derived entities that allows one to specify files to be copied (and optionally filtered as templates) at runtime during installation, and have that be part of the default customize script.

@aledsage
Copy link
Member

Looks good. Merging.
We'll address (hopefully in M3) the mass of methods on AbstractSoftwareProcessSshDriver, and try to get more consistency across SshMachineLocation etc.

aledsage added a commit that referenced this pull request Feb 13, 2013
Make copyResource and copytemplate usable by all entity drivers
@aledsage aledsage merged commit 25e9e9f into brooklyncentral:master Feb 13, 2013
@aledsage
Copy link
Member

p.s. it's a good idea to have commit comments including context in their first line, rather than just "Review comment changes". This will appear later when someone does git log or git blame.

@buildhive
Copy link

Brooklyn Central » brooklyn #83 SUCCESS
This pull request looks good
(what's this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants