-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copyResource and copytemplate usable by all entity drivers #528
Conversation
Brooklyn Central » brooklyn #60 SUCCESS |
result = getMachine().execCommands("download", | ||
ImmutableList.of( | ||
CommonCommands.INSTALL_CURL, | ||
String.format("curl --silent --insecure %s -o %s", resource, dest))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also want -f
in curl command. Otherwise a 404 that returns a html page about it is considered a success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Definitely useful stuff here. But I'm not sure about adding all this stuff directly to AbstractSoftwareProcessDriver.java and AbstractSoftwareProcessSshDriver.java |
Where else could mechanisms to copy runtime files go, though? I think the use cases are quite clear. Actually, I'd like to add a config key to all |
Looks good. Merging. |
Make copyResource and copytemplate usable by all entity drivers
p.s. it's a good idea to have commit comments including context in their first line, rather than just "Review comment changes". This will appear later when someone does |
Brooklyn Central » brooklyn #83 SUCCESS |
No description provided.