TemplateResponse now stores Request object in _request, to avoid over-write by django.test.client.Client

Author: Simon Willison

django_openid/response.py

@@ -67,7 +67,10 @@ def _set_content(self, value):
 class TemplateResponse(SimpleTemplateResponse):
 
     def __init__(self, request, template, context, *args, **kwargs):
-        self.request = request
+        # unlike template_context and template_name the _request should not 
+        # be considered part of the public API.
+        self._request = request
         super(TemplateResponse, self).__init__(
             template, context, *args, **kwargs
         )
@@ -76,7 +79,7 @@ def resolve_context(self, context):
         if isinstance(context, Context):
             return context
         else:
-            return RequestContext(self.request, context)
 
 # Even less verbose alias:
 render = TemplateResponse

django_openid/tests/auth_tests.py

@@ -161,4 +161,6 @@ def testRecoverAccountByUsername(self):
         self.assertEqual(
             response.template_name, 'django_openid/recovery_complete.html'
         )
+        self.assertEqual(response._request.user.username, 'noopenids')
+