Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't build with -fno-common #10

Closed
clausecker opened this issue Aug 17, 2021 · 1 comment
Closed

Doesn't build with -fno-common #10

clausecker opened this issue Aug 17, 2021 · 1 comment

Comments

@clausecker
Copy link

Good day!

Version 0.36 doesn't build with -fno-common, an option that has been the default with some newer compilers for a while.

To fix this problem, two one-line changes are needed. In semantics.c, add an extern keyword to the declaration of yyin:

-FILE *yyin;
+extern FILE *yyin;

and similarly, in tumble_input.h add such a keyword to the declaration of blank_handler:

-input_handler_t blank_handler;
+extern input_handler_t blank_handler;

This fixes the build on current FreeBSD.
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Aug 19, 2021
@clausecker @fernape
graphics/tumble: Unbreak with -fno-common
9ff864c 
Submitter becomes MAINTAINER. Already maintainer of several ports.

Ref: brouhaha/tumble#10

PR:	257913
MFH:	2021Q3
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Aug 19, 2021
@clausecker @fernape
graphics/tumble: Unbreak with -fno-common
b5a7b44 
Submitter becomes MAINTAINER. Already maintainer of several ports.

Ref: brouhaha/tumble#10

PR:	257913
MFH:	2021Q3
(cherry picked from commit 9ff864c)
@brouhaha
Copy link
Owner

Should be fixed in master now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clausecker @brouhaha