-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat jordan collabs #135
Feat jordan collabs #135
Conversation
Visit the preview URL for this PR (updated for commit 6bfd82d): https://ccv-brown-edu--pr135-feat-jordan-collabs-qgd01u2v.web.app (expires Tue, 20 Sep 2022 18:40:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes Jordan! Almost there !!
- category: code | ||
url: https://github.com/compbiocore/NLP_Syllabi_Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link leads to a 404. Is it private? Can it be public? If not, let's just delete these lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need to remain private, let me double-check with Ashok and get back to this. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked, we're good and this is public now!
our-work/software/nmr-web-app.yml
Outdated
@@ -0,0 +1,15 @@ | |||
title: NMR Web Application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the full name of NMR in the title since I wouldn't expect users to be familiar with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change now, thank you!
- category: code | ||
url: https://github.com/compbiocore/NMR-WebApp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also can't access this repo. Is it public? If not, let's remove this !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made public!
Co-authored-by: Ellen Duong <ellen_duong1@brown.edu>
…e-content into feat-jordan-collabs "Updated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for getting this updated! 🚢
@j-stat this was approved but never merged ;) - do you want to pull in main and if tests pass, merge? |
Yes, sorry, absolutely! Thank you!
…On Mon, Nov 14, 2022 at 12:21 PM Maria Isabel Restrepo < ***@***.***> wrote:
@j-stat <https://github.com/j-stat> this was approved but never merged ;)
- do you want to pull in main and if tests pass, merge?
—
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASLD5QSXTFF53KQXODD5KOTWIJYIPANCNFSM6AAAAAAQK3K5GA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Visit the preview URL for this PR (updated for commit c54155f): https://ccv-brown-edu--pr135-feat-jordan-collabs-hei9ub20.web.app (expires Mon, 21 Nov 2022 18:48:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
Updated pull request for Jordan's projects to be listed under software