Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat jordan collabs #135

Merged
merged 16 commits into from
Nov 14, 2022
Merged

Feat jordan collabs #135

merged 16 commits into from
Nov 14, 2022

Conversation

j-stat
Copy link
Contributor

@j-stat j-stat commented Sep 12, 2022

Updated pull request for Jordan's projects to be listed under software

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Visit the preview URL for this PR (updated for commit 6bfd82d):

https://ccv-brown-edu--pr135-feat-jordan-collabs-qgd01u2v.web.app

(expires Tue, 20 Sep 2022 18:40:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes Jordan! Almost there !!

our-work/software/nlp-syllabi.yml Outdated Show resolved Hide resolved
Comment on lines +15 to +16
- category: code
url: https://github.com/compbiocore/NLP_Syllabi_Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link leads to a 404. Is it private? Can it be public? If not, let's just delete these lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to remain private, let me double-check with Ashok and get back to this. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, we're good and this is public now!

@@ -0,0 +1,15 @@
title: NMR Web Application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the full name of NMR in the title since I wouldn't expect users to be familiar with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change now, thank you!

Comment on lines +14 to +15
- category: code
url: https://github.com/compbiocore/NMR-WebApp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also can't access this repo. Is it public? If not, let's remove this !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made public!

j-stat and others added 3 commits September 13, 2022 14:21
Co-authored-by: Ellen Duong <ellen_duong1@brown.edu>
…e-content into feat-jordan-collabs

"Updated"
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for getting this updated! 🚢

@mirestrepo
Copy link
Member

@j-stat this was approved but never merged ;) - do you want to pull in main and if tests pass, merge?

@j-stat
Copy link
Contributor Author

j-stat commented Nov 14, 2022 via email

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit c54155f):

https://ccv-brown-edu--pr135-feat-jordan-collabs-hei9ub20.web.app

(expires Mon, 21 Nov 2022 18:48:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@j-stat j-stat merged commit 806fb22 into main Nov 14, 2022
@j-stat j-stat deleted the feat-jordan-collabs branch November 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants