ref: Refactor photodiodeSpot and photodiodeGhostBox
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the original name of function. Returning to that name as it's more prescriptive, will wait to change until the bigger change in v4
|
Visit the preview URL for this PR (updated for commit df9045e): https://ccv-honeycomb--pr337-ref-photodiode-spot-n8uhx51l.web.app (expires Wed, 20 Dec 2023 19:08:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
galenwinsor
reviewed
Dec 11, 2023
| * Pulses the photodiode spot from black (on) to white (off) and runs a callback function | ||
| * @param {number} ms The amount of time to flash the photodiode spot | ||
| * @param {function} callback A callback function to execute after the flash | ||
| */ | ||
| function pulseFor(ms, callback) { | ||
| $(".photodiode-spot").css({ "background-color": "black" }); |
There was a problem hiding this comment.
There's jQuery in this???
There was a problem hiding this comment.
Oh yeah! I'm afraid to touch it 😨
galenwinsor
reviewed
Dec 11, 2023
| } | ||
| const photodiodeGhostBox = div(span("", { id: "photodiode-spot", class: "photodiode-spot" }), { | ||
| id: "photodiode-box", | ||
| class: config.USE_PHOTODIODE ? "photodiode-box visible" : "photodiode-box invisible", |
There was a problem hiding this comment.
Is config guaranteed to be defined when this is run? It always makes me a little nervous to put conditional stuff at the top level.
There was a problem hiding this comment.
It is, but I agree I'd like to change it at some point.
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Dec 12, 2023
Merged
broarr
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
photodiodeGhostBoxis now exported as a constant instead of a functionphotodiodeSpotaspdSpotEncodeThe original name for the photodiode function was
pdSpotEncode. I'm returning to that name - I think it's a little more prescriptive and it'll be nice for users to have that consistent naming. Eventually we're going to turn it into a custom jsPsych extension, we can think about renaming then.closes #322