Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: page ledes in CMS #76

Merged
merged 4 commits into from
Jul 24, 2024
Merged

feat: page ledes in CMS #76

merged 4 commits into from
Jul 24, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Jul 23, 2024

This PR allows David's team to edit certain pages' content - the downside is that the pages will be a bit less pretty, but the upside is that David won't have to keep paying us while we are waiting for his team to come up with web-focused content.

Keep in mind that import * as lede might state that it is not being used, which is incorrect.

@hetd54 hetd54 requested a review from galenwinsor July 23, 2024 13:45
Copy link

Visit the preview URL for this PR (updated for commit 9f94fc2):

https://mmp-site-b1c9b--pr76-feat-pages-cms-wdpzbn0j.web.app

(expires Tue, 30 Jul 2024 13:48:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link
Collaborator

@anna-murphy anna-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE how this cleans everything up. Well done!!!

@@ -4,6 +4,8 @@ import Home from "../layouts/Home.astro"
import MiniMapSvg from "../components/svg/MiniMaps"
import FootPrint from "../components/svg/FootPrint"
import ProjectAim from "../components/ProjectAim.astro"
// this import IS used -- see line 21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cant js figure this out?? thats so weird...

@hetd54 hetd54 self-assigned this Jul 24, 2024
@hetd54 hetd54 merged commit ba38ac4 into main Jul 24, 2024
2 checks passed
@hetd54 hetd54 deleted the feat-pages-cms branch July 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants