-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi call roles #4
base: main
Are you sure you want to change the base?
Conversation
Love the suggestion here! Thank you! But could we fix the PR so it's easier to review? Most of the changes look like they could be in a |
OK I have fixed the formatting -now with 4 spaces tab width. (I was using 2 spaces tab width). Sorry I am trying to understand your comment: Anyway I added Let me know. |
Right. Sorry it's been hard to see what your changes are doing. I think this one too is just looking to implement this with hardhat? Could you check this repo and see if it has everything you need? |
Thank you for replying my request. I will check it out and let you know.
…On Mon, 21 Mar 2022 at 7:52 PM, Patrick Collins ***@***.***> wrote:
Right. Sorry it's been hard to see what your changes are doing.
I think this one too is just looking to implement this with hardhat? Could
you check this repo and see if it has everything you need?
https://github.com/PatrickAlphaC/dao-template
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFSXJ6EKEGAMDWAREUV4QLVBBPIBANCNFSM5RBR2YWQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Below are your comments in the script file
So, I was trying to do multicall to set the roles and at the same time do it hardhat task. What I should have done is implement it in brownie/python script - this would be a clearer "pull request". I learnt my mistake and sorry I make you confuse. |
Ahhhhh, yes exactly! |
Now with multicall to grant and revoke roles.