Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi call roles #4

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

azizazlan
Copy link

Now with multicall to grant and revoke roles.

@PatrickAlphaC
Copy link
Contributor

Love the suggestion here! Thank you!

But could we fix the PR so it's easier to review? Most of the changes look like they could be in a .gitignore

@azizazlan
Copy link
Author

OK I have fixed the formatting -now with 4 spaces tab width. (I was using 2 spaces tab width).

Sorry I am trying to understand your comment:
Most of the changes look like they could be in a .gitignore

Anyway I added artifacts and [._]*.s[a-v][a-z] in the file because I am using vim as the editor.

Let me know.

@PatrickAlphaC
Copy link
Contributor

Right. Sorry it's been hard to see what your changes are doing.

I think this one too is just looking to implement this with hardhat? Could you check this repo and see if it has everything you need?

https://github.com/PatrickAlphaC/dao-template

@azizazlan
Copy link
Author

azizazlan commented Mar 23, 2022 via email

@azizazlan
Copy link
Author

Below are your comments in the script file deploy_and_run.py

    # Now, we set the roles...
    # Multicall would be great here ;)

So, I was trying to do multicall to set the roles and at the same time do it hardhat task.

What I should have done is implement it in brownie/python script - this would be a clearer "pull request".

I learnt my mistake and sorry I make you confuse.

@PatrickAlphaC
Copy link
Contributor

Ahhhhh, yes exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants