feat: mark Client app_id and app_secret parameters as deprecated
#1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
browniebroke
commented
May 20, 2024
•
browniebroke
commented
- Include tests for bug fix and new functionality
- Updated documentation for new feature
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable/6.x #1047 +/- ##
=============================================
Coverage ? 99.86%
=============================================
Files ? 19
Lines ? 721
Branches ? 56
=============================================
Hits ? 720
Misses ? 0
Partials ? 1 ☔ View full report in Codecov by Sentry. |
browniebroke
force-pushed
the
feat/deprecate-app-id-secret
branch
from
836e390
to
c5be081
Compare
browniebroke
changed the title
app_id and app_secret parameters as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.