Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packaging: switch to Poetry #196

Merged
merged 5 commits into from
Oct 13, 2020
Merged

feat(packaging: switch to Poetry #196

merged 5 commits into from
Oct 13, 2020

Conversation

browniebroke
Copy link
Owner

  • Include tests for bug fix and new functionality
  • Updated documentation for new feature

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.91%.

Quality metrics Before After Change
Complexity 0.00 0.00 0.00
Method Length 129.00 😞 106.00 🙂 -23.00 👍
Working memory 10.00 😞 10.00 😞 0.00
Quality 65.28% 🙂 68.19% 🙂 2.91% 👍
Other metrics Before After Change
Lines 269 193 -76
Changed files Quality Before Quality After Quality Change
docs/source/conf.py 65.28% 🙂 68.19% 🙂 2.91% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@browniebroke browniebroke changed the title Switch to Poetry feat(packaging: switch to Poetry Oct 13, 2020
@browniebroke browniebroke merged commit a8d3068 into main Oct 13, 2020
@browniebroke browniebroke deleted the poetry branch October 13, 2020 21:20
browniebroke added a commit that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant