Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for PHP 8.0 #321

Closed
wants to merge 2 commits into from
Closed

Conversation

duxthefux
Copy link
Contributor

@duxthefux duxthefux commented Dec 15, 2020

Fixes #320

composer.json Outdated Show resolved Hide resolved
@asgrim asgrim self-assigned this Dec 15, 2020
@asgrim
Copy link
Member

asgrim commented Dec 15, 2020

@duxthefux thanks for this; I've seen we're still using Travis on this build which has ended for open source now; I'll try and find some time to incorporate this into a new PR which adds GitHub actions builds.

Co-authored-by: James Titcumb <james@asgrim.com>
@duxthefux
Copy link
Contributor Author

@asgrim thanks for the suggestions. I accepted it and committed it.

Do you see any other blocker for merging it and creating a new release?

@asgrim
Copy link
Member

asgrim commented Dec 15, 2020

@duxthefux my main issue is the CI build doesn't show whether we're actually passing at the moment (since there basically is none). We'll sort that separately though I think (see #318) ... there may be other changes to go in to ensure compatibility.

@asgrim
Copy link
Member

asgrim commented Dec 18, 2020

I've merged this change into #323 - thanks @duxthefux !

@asgrim asgrim closed this Dec 18, 2020
@asgrim
Copy link
Member

asgrim commented Jan 6, 2021

@duxthefux sorry for the delay: https://github.com/browscap/browscap-php/releases/tag/5.0.0 this is now released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PHP 8 // Project still alive?
3 participants