-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use default require.extensions
#138
Conversation
Fixes tape-testing/tape#396 Fixes #137 & Fixes tape-testing/tape#395 by using default `require.extensions` collection instead of the magic Array `['.js']`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change, because require.extensions
defaults to have .js
, .json
, and .node
- I'm not sure it's a particularly good idea to do in resolve
.
@ljharb to be clear this means library authors who depend on resolve would need to inform User Land to not use Thanks for considering this! And happy Friday! 🎉 |
Having |
My point exactly. We see eye to eye. |
@snuggs it seems you've deleted your fork, which makes this PR permanently unrecoverable, which is a shame because it'd be reasonable to land in v2. |
Any way I can push this back up? Or has the ship left the port? Happy New Year! |
Unfortunately once a fork is deleted, there's no way to recover a PR, so this PR's ref will forever pollute the repo, unmergeable :-( I think that a new PR would be reasonable, but I don't think blindly using
|
Fixes #137, Addresses #134, & Fixes tape-testing/tape#395 by using default
require.extensions
collection instead of the magic Array['.js']
Closes #166.