fix: yarn warning for invalid bin entry #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jan 19, 2020
| @@ -18,7 +18,9 @@ | |||
| "tape": "~2.3.2", | |||
| "typedarray": "0.0.6" | |||
| }, | |||
| "bin": "./bin.js", | |||
| "bin": { | |||
| "shajs": "./bin.js" | |||
There was a problem hiding this comment.
You could wait for yarnpkg/yarn#7811 to be released. This might allow to fix this without a breaking change.
There was a problem hiding this comment.
Thanks man, this was already merged. I hope the author will finally merge this one here ?
This was referenced Feb 10, 2020
|
note: no need to merge this, since it's a yarn issue... and has been fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Removed the dot in the binary name.
Closes #64
Can be verified locally. A
yarnin the source directory will not warn about invalid bin entries on this branch.