Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix issue with hidden second line of tabs When there are two lines #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eddy5885
Copy link

electron-tabs

When there are multiple lines of tabs, the second line is not visible.Because the grandfather tag of the tabs has a fixed height of 32px, the second line and onwards are hidden when there are multiple rows. Removing the fixed height and allowing the height to adapt automatically can fix this issue. Additionally, if the z-index of the content area of the web view is too high, the tabs may not be visible.

This issue can be fixed by following: #128
@da201501245

@eddy5885 eddy5885 changed the title Fix:When there are multiple lines of tabs, the second line is not vis… Fix issue with hidden second line of tabs When there are two lines Apr 14, 2023
@SudoVanilla
Copy link

In apps, I think tabs tend to scroll sideways instead of stacking...

Example, my app that uses Electron Tabs:

Screen.Recording.2023-05-09.at.10.02.46.PM.mov

Example, macOS Finder:

Screen.Recording.2023-05-09.at.10.00.53.PM.mov

@eshwaruppala
Copy link

@SudoVanilla you got a cool implementation. whats your app name?

@SudoVanilla
Copy link

@eshwaruppala That app I've built with Electron Tabs is Penpot Desktop.
Source code is at https://sudovanilla.com/code/Korbs/Penpot-Desktop/.

@eshwaruppala
Copy link

eshwaruppala commented Nov 29, 2023

@SudoVanilla Thanks for the prompt reply. I am going through the code and trying to understand how you built it. How can i theme my tabs like yours? The scrollbar is due to the fix you added using css?

Edit: I got it :)

@SudoVanilla
Copy link

Closed this issue if it doesn't need to be opened anymore.
Really, a simple CSS fix can be done by the developer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants