Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several links to ftp://opendata.dwd.de in documentation fail #29

Closed
tillschwoerer opened this issue Apr 13, 2021 · 2 comments
Closed

Several links to ftp://opendata.dwd.de in documentation fail #29

tillschwoerer opened this issue Apr 13, 2021 · 2 comments

Comments

@tillschwoerer
Copy link

Dear Berry,

I noticed that several links in your bookdown documentation of the package to the opendata platform of DWD are not working properly. The reason seems to be that urls have changed from ftp://opendata.dwd.de to https://opendata.dwd.de/

For instance in 1. Intro it must be https://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf rather than ftp://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf. The same applies also, e.g. to all the links provided in section 4 Available Datasets.

Best regards
Till

@brry
Copy link
Owner

brry commented Apr 13, 2021

Hi Till,

thanks for reporting this!
For me on Firefox, the FTP link opens just fine (although github markdown doesn't link to it):
ftp://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf

when searching for Github markdown FTP, I found go-gitea/gitea#8478 (comment) where @guillep2k writes that Google Chrome 82 won't support FTP anymore.

For Chrome users, I could add references to the html pages aditionally to the FTP pages.
In section 4 Available Datasets, I would have to replace all urls, as having two is not feasable there.

I need to think about this a bit more.
I generally like the look of the FTP interface better and it is where rdwd gets all the data by default...
On the other hand, I would like the website to be usable for all users...

@brry
Copy link
Owner

brry commented Apr 23, 2021

Firefox now also pulled the plug on FTP, so I'm replacing all ftp links with https throughout the package.
The internal dwdbase, indexFTP etc will keep using FTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants