refactor: change the github icon to the corner of the page #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kawanofer is attempting to deploy a commit to the Meg IT Team on Vercel. A member of the Team first needs to authorize it. |
brunocroh
requested changes
Jun 7, 2024
apps/web/lib/utils.ts
Outdated
There was a problem hiding this comment.
remove this file from commit, it is not related to bug fix
packages/env-config/index.ts
Outdated
There was a problem hiding this comment.
remove this file from commit, it is not related to bug fix
apps/web/components/header.tsx
Outdated
Comment on lines
17
to
23
| <Link | ||
| href="https://github.com/brunocroh/bolhadev.chat" | ||
| target="_blank" | ||
| className="absolute right-0 top-0" | ||
| > | ||
| <GithubCorner /> | ||
| </Link> |
There was a problem hiding this comment.
Now this component is outside the bounds of the header, so move it outside the header, the main layout component will be a good place
brunocroh
approved these changes
Jun 7, 2024
|
Awesome, thank you mate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31