Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace oleksandr/bonjour with grandcat/zeroconf #86

Closed
wants to merge 1 commit into from

Conversation

nickw444
Copy link

@nickw444 nickw444 commented Aug 5, 2017

Replace oleksandr/bonjour with grandcat/zeroconf.

Fortunately for me, there was only a single API difference between the two versions, this being zeroconf.RegisterProxy now accepting a list of IP's. I have inlined the creation of this structure, however happy to change to whatever style is suited best to this project.

TODO:

@nickw444 nickw444 changed the title WIP: Replace oleksandr/bonjour with grandcat/zeroconf Replace oleksandr/bonjour with grandcat/zeroconf Aug 13, 2017
@nickw444
Copy link
Author

After replacing the library, the consistency of the bridge being accessible appears to be much more reliable. There are occasionally dropouts, but I think i'm going to pass the blame for this onto poor wifi reception.

@nickw444
Copy link
Author

Regardless of whether this resolves the issue or not, I still think this library should be used in favour of the one from oleksandr, since it is actively maintained (and is a fork):

Great thanks to hashicorp and to oleksandr and all contributing authors for the code this projects bases upon. Large parts of the code are still the same.

However, there are several reasons why I decided to create a fork of the original project: The previous project seems to be unmaintained. There are several useful pull requests waiting. I merged most of them in this project. Still, the implementation has some bugs and lacks some other features that make it quite unreliable in real LAN environments when running continously. Last but not least, the aim for this project is to build a solution that targets standard conformance in the long term with the support of the community. Though, resiliency should remain a top goal.

@tomtaylor
Copy link
Contributor

Highly suggest merging this, it worked well for me.

@nickw444
Copy link
Author

nickw444 commented Sep 6, 2017

Likewise, haven't had a connection issue since I last posted

@brutella
Copy link
Owner

Thanks for your effort.

In the meantime, I've made a dnssd library which is used in HomeControl in the dnssd branch.

@nickw444 nickw444 closed this Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants