Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/local storage #6

Merged

Conversation

rajanchavda
Copy link
Contributor

Improvement

  1. Saved DOB in the local storage
  2. Added KeyUp/Down in Month and Day fields

@bryanbraun bryanbraun self-requested a review August 5, 2021 19:47
Copy link
Owner

@bryanbraun bryanbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR here. These are some solid improvements.

Just one request: currently, if a user has never entered a date of birth, we get an error in the Javascript console:

image

I think we can fix this by checking if DOB is null near line 126 and exiting early if so.

If you can make this update then I'll go ahead and merge. 👍

@rajanchavda
Copy link
Contributor Author

rajanchavda commented Aug 6, 2021

Hey thanks for the PR here. These are some solid improvements.

Just one request: currently, if a user has never entered a date of birth, we get an error in the Javascript console:

image

I think we can fix this by checking if DOB is null near line 126 and exiting early if so.

If you can make this update then I'll go ahead and merge.

Fixed the issue. Please check.

@bryanbraun bryanbraun merged commit e28c794 into bryanbraun:gh-pages Aug 6, 2021
@bryanbraun
Copy link
Owner

Works like a charm! Thanks again for the contribution. 🙇

@bryanbraun bryanbraun mentioned this pull request Aug 6, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants