Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #2

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Improve code quality #2

merged 1 commit into from
Sep 8, 2022

Conversation

bryanljx
Copy link
Owner

@bryanljx bryanljx commented Sep 8, 2022

Context

Improve code quality as per A-CodeQuality. Resolved comments on coding style left by reviewers from last week.

Changes

  • Refactored string concatenation in loops to use StringBuilder

There were a few cases where String concatenation was used within
a loop instead of StringBuilder, which is not ideal due to
performance reasons. This was fixed in this commit.
@bryanljx bryanljx changed the title Add generate primes Improve code quality Sep 8, 2022
@bryanljx bryanljx merged commit 4baa0c3 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant