Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in net flux calculation? #56

Open
schwancr opened this issue Nov 21, 2013 · 0 comments
Open

bug in net flux calculation? #56

schwancr opened this issue Nov 21, 2013 · 0 comments

Comments

@schwancr
Copy link

When you calculate the net flux you have to calculate the forward flux for each edge, and throw out the edges that have negative flux. When you do this (https://github.com/brycecr/msmexplorer/blob/master/MSMExplorer/src/edu/stanford/folding/msmexplorer/tpt/TPTFactoryCM.java#L302-L310) you have fFlux that contains the total flux along each edge, but you are modifying it on the fly to compute the net flux.

The problem with doing this, is when you modify fFlux(i, j), now the net flux on edge (j, i) will be calculated incorrectly.
schwancr added a commit to schwancr/msmexplorer that referenced this issue Nov 21, 2013
@schwancr
suggested fix to net_flux problem raised in issue brycecr#56
9326abc
schwancr added a commit to schwancr/msmexplorer that referenced this issue Nov 26, 2014
@schwancr
fix to issue brycecr#56
c91df94
brycecr added a commit to pandegroup/msmexplorer that referenced this issue Dec 10, 2014
@brycecr
Merge pull request #3 from schwancr/flux_fix
cada12a 
fix to issue brycecr#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schwancr