Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when processing items where from property is not set #1

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

plopesc
Copy link

@plopesc plopesc commented Mar 23, 2018

Hello,
Running your Drupal module I found an error that made my site unresponsive.

( ! ) Notice: Undefined property: stdClass::$from in /var/www/site/vendor/brynj-digital/social-feed/src/SocialFeed.php on line 411

I did some debug, and improved the if statement to avoid errors.

Thank you

@danjdewhurst danjdewhurst merged commit a9b05c6 into brynj-digital:master Apr 24, 2018
@danjdewhurst
Copy link
Collaborator

Thank you @plopesc, this has now been merged and I will create a release right away.

@plopesc plopesc deleted the patch-1 branch April 24, 2018 11:35
Repository owner locked as resolved and limited conversation to collaborators Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants