add dict_util key_path tuple and list support
#164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
requested changes
Dec 1, 2017
dictutil/dictutil.py
Outdated
| if isinstance(key_path, basestring): | ||
| _keys = key_path.split('.') | ||
|
|
||
| if _keys == [''] or _keys == ('',): |
There was a problem hiding this comment.
如果_keys不是split出来的,空字符串应该是个正确的输入..
想了下, 如果输入的key_path是空串好像也应该是个正确的输入, 这些都应该是正确的: "", ".", ".." 分别表示:x[""], x[""][""], x[""][""][""]. 你觉得来?
dictutil/dictutil.py
Outdated
| k=k, vars=vars)) | ||
| else: | ||
| key = k | ||
| raise e |
There was a problem hiding this comment.
重新捕捉后的raise,直接写raise, 不加参数,可以保留原始的堆栈. 94行这样写就不造原始的e是哪里抛出的.
dictutil/dictutil.py
Outdated
| return k | ||
|
|
||
|
|
||
| def _replace_var_str(k): |
There was a problem hiding this comment.
replace好像不太合适, 叫translate吧.
drmingdrmer
requested changes
Dec 2, 2017
dictutil/test/test_dictutil.py
Outdated
| @@ -292,7 +292,7 @@ def test_getter_str(self): | |||
| ('', | |||
| [''], | |||
| ('',), | |||
| 'lambda dic, vars={}: dic' | |||
| 'lambda dic, vars={}: dic.get("", vars.get("_default", 0))' | |||
There was a problem hiding this comment.
增加多个点的测试吧. "." "x." ".x.." 这些都应该是合法的.
drmingdrmer
approved these changes
Dec 2, 2017
13yu
approved these changes
Dec 4, 2017
tongwei
force-pushed
the
tongwei_dictutil_keypath
branch
from
9cdac8f
to
f249847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.