chore: return a false, not an err when unmarshling fails

bschaatsbergen · Mar 16, 2024 · 631de14 · 631de14
1 parent f6fea7b
commit 631de14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/provider/valid_json_function.go b/internal/provider/valid_json_function.go
@@ -29,7 +29,7 @@ func (r ValidJSONFunction) Definition(_ context.Context, _ function.DefinitionRe
 		Summary: "Checks whether a string is valid JSON",
 		Parameters: []function.Parameter{
 			function.StringParameter{
-				AllowNullValue:     false,
+				AllowNullValue:     true,
 				AllowUnknownValues: true,
 				Description:        "The JSON string to check",
 				Name:               "json",
@@ -50,7 +50,7 @@ func (r ValidJSONFunction) Run(ctx context.Context, req function.RunRequest, res
 	isValidJSON, err := isValidJSON(JSON)
 	if err != nil {
 		resp.Error = function.ConcatFuncErrors(resp.Error, function.NewFuncError(err.Error()))
-		return
+		resp.Error = function.ConcatFuncErrors(resp.Result.Set(ctx, false))
 	}
 
 	resp.Error = function.ConcatFuncErrors(resp.Result.Set(ctx, isValidJSON))

diff --git a/internal/provider/valid_yaml_function.go b/internal/provider/valid_yaml_function.go
@@ -50,7 +50,7 @@ func (r ValidYAMLFunction) Run(ctx context.Context, req function.RunRequest, res
 	isValidYAML, err := isValidYAML(YAML)
 	if err != nil {
 		resp.Error = function.ConcatFuncErrors(resp.Error, function.NewFuncError(err.Error()))
-		return
+		resp.Error = function.ConcatFuncErrors(resp.Result.Set(ctx, false))
 	}
 
 	resp.Error = function.ConcatFuncErrors(resp.Result.Set(ctx, isValidYAML))