-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cli #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shichen85
commented
Sep 25, 2020
- Add unit test for jsonify
- Add import module CLI
- Add batch import sound function
- Add import sounds CLI
test. feat: Add unit test for the jsonify module.
to separate functions and add corresponding unit tests.
convertGms2FilesToJson refactor: Require path argument to jsonify CLI and update the pre-commit hook to use `npx gms2 jsonify --path .` refactor: Replace "foreach" loop with "for of" loop refactor: Change CLI options use kabob case refactor: Enforce trimming of CLI inputs at top level to filter out empty space inputs feat: Add unit test for addsounds with subset of allowed extensions
extensions and add unit test for it.
extensions are provided.
Many changes requested after code review -- awaiting new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.