Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cli #1

Closed
wants to merge 20 commits into from
Closed

Feat/cli #1

wants to merge 20 commits into from

Conversation

shichen85
Copy link
Member

  • Add unit test for jsonify
  • Add import module CLI
  • Add batch import sound function
  • Add import sounds CLI

test.
feat: Add unit test for the jsonify module.
to separate functions and add corresponding unit tests.
convertGms2FilesToJson
refactor: Require path argument to jsonify CLI and update the pre-commit
hook to use `npx gms2 jsonify --path .`
refactor: Replace "foreach" loop with "for of" loop
refactor: Change CLI options use kabob case
refactor: Enforce trimming of CLI inputs at top level to filter out
empty space inputs
feat: Add unit test for addsounds with subset of allowed extensions
@adam-coster
Copy link
Member

Many changes requested after code review -- awaiting new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants