Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cli #3

Merged
merged 26 commits into from
Sep 29, 2020
Merged

Feat/cli #3

merged 26 commits into from
Sep 29, 2020

Conversation

shichen85
Copy link
Member

@shichen85 shichen85 commented Sep 29, 2020 •
edited
Loading

Bugfixes and implemented CLIs.

@shichen85
refactor: Move jsonify function to its own file for exporting for unit
11d89f2 
test.
feat: Add unit test for the jsonify module.
@shichen85
feat: Add version display to the help text of the CLI main command.
70f1922
@shichen85
feat: Add CLI command for importing modules and corresponding unit test.
4a9599f
@shichen85
refactor: Separate the concern of jsonify function to have its own unit
ae67b49 
test.
@shichen85
refactor: Separate the concern of jsonify a single file vs a directory
ad55420 
to separate functions and add corresponding unit tests.
@shichen85
refactor: Refactor the unit test for jsonify CLI command.
1ef28dd
@shichen85
refactor: Refactor import module CLI to validate the input and add unit
8283f62 
tests.
@shichen85
fix: Change Jsonify CLI function to call the appropriate methods based
dd18ba3 
on the input.
@shichen85
feat: Add unit tests for CLI success cases for jsonify and module
63d9065 
import.
@shichen85
refactor: Add feedback for assertAtLeastOneTruthy.
6954a2d
@shichen85
feat: Add batch sound import function and unit test.
b0fdcc0
@shichen85
feat: Add import sounds CLI function and unit tests.
5b2019e
@shichen85
refactor: change to the file/folder input model for addSound and
82c395a 
convertGms2FilesToJson
refactor: Require path argument to jsonify CLI and update the pre-commit
hook to use `npx gms2 jsonify --path .`
refactor: Replace "foreach" loop with "for of" loop
refactor: Change CLI options use kabob case
refactor: Enforce trimming of CLI inputs at top level to filter out
empty space inputs
feat: Add unit test for addsounds with subset of allowed extensions
@shichen85
fix: Update CLI unit tests to allow using relative paths.
6de8d32
@shichen85
feat: Allow addIncludedFiles function to filter target files by
6e070e7 
extensions and add unit test for it.
@shichen85
feat: Add the import file CLI command.
b687f95
@shichen85
fix: Change CLI parsed inputs to use camel case.
4292e68
@shichen85
fix: Ensure that import sounds and files CLI functions work when no
08c0e6b 
extensions are provided.
@shichen85
chore: Removed debug info.
10f97a8
@shichen85
fix: CLI batch import sounds now recursively discovers file in the given
d130cfe 
directory.
@shichen85
fix: Ensure that creating new resources will put them in the correct
bdba641 
project path.
@shichen85
fix: Ensure included files are added to the correct project path.
e0b6001
@shichen85
fix: Change the import included files unit test to be recursive.
463a0dd
@shichen85
fix: Removed the redundant static resourceRoot variable in
353b723 
Gms2Resource classes.
@shichen85
chore: Renaming and mocha revision.
99650e4
@shichen85
fix: Add sanity check for audio import's absolute path.
2944602
@adam-coster adam-coster merged commit 6b76979 into develop Sep 29, 2020
@adam-coster adam-coster deleted the feat/cli branch September 29, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shichen85 @adam-coster