Use flycheck's new :default-directory option to handle projects with subdirs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subdirs This enables the checker if and only if an existing elm-package.json can be found, and runs elm-make from the directory of that file. The previous behaviour of allowing elm-make to implicitly create elm-package.json in the current directory - which could cause the checker initialisation to hang - is also therefore avoided. Fixes bsermons#3.
Closed
|
Thanks for this! I had been watching that flycheck PR for a while so glad it finally landed. As long as it works with MELPA that is good enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the checker if and only if an existing elm-package.json can be found, and runs elm-make from the directory of that file.
The previous behaviour of allowing elm-make to implicitly create elm-package.json in the current directory - which could cause the checker initialisation to hang - is also therefore avoided. Initial invocation of elm-make is best carried out interactively, rather than implicitly.
Fixes #3, but is pending the next flycheck release: 0.29. This code works with the current MELPA snapshot package though, so you might consider committing this already, then not tagging a new stable version of flycheck-elm until the next flycheck stable release has been made.