forked from abalabahaha/eris
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphabetize jsdoc comments and methods in classes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added oldMessage.pinned to typings. idk if it is supposed to be null or undefined though.
jtsshieh
changed the title
Alphabetize oldPresence, oldState, oldMessage, oldRole, and emoji
Alphabetize jsdoc comments
Aug 19, 2020
if you can, please merge my pr into this your fork because I updated oldChannel and oldRole. Don't want any conflicts there. (or all the latest dev branch changes). |
Please correct if wrong, i don't write typings usually
please check if the typings are correct here
Client still needs to be "alphabetized" |
jtsshieh
changed the title
Alphabetize jsdoc comments
Alphabetize jsdoc comments and methods in classes
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
You should probably wait because i'm resolving the merge conflicts and that might change things |
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
reviewed
Aug 20, 2020
bsian03
requested changes
Aug 20, 2020
bsian03
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added oldMessage.pinned to typings. idk if it is supposed to be null or undefined though.