Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize jsdoc comments and methods in classes #2

Merged
merged 36 commits into from
Aug 20, 2020

Conversation

jtsshieh
Copy link

also added oldMessage.pinned to typings. idk if it is supposed to be null or undefined though.

also added oldMessage.pinned to typings. idk if it is supposed to be null or undefined though.
@jtsshieh jtsshieh changed the title Alphabetize oldPresence, oldState, oldMessage, oldRole, and emoji Alphabetize jsdoc comments Aug 19, 2020
@jtsshieh
Copy link
Author

if you can, please merge my pr into this your fork because I updated oldChannel and oldRole. Don't want any conflicts there. (or all the latest dev branch changes).

@jtsshieh
Copy link
Author

Client still needs to be "alphabetized"

@jtsshieh jtsshieh marked this pull request as ready for review August 20, 2020 14:09
@jtsshieh jtsshieh changed the title Alphabetize jsdoc comments Alphabetize jsdoc comments and methods in classes Aug 20, 2020
index.d.ts Outdated Show resolved Hide resolved
@jtsshieh
Copy link
Author

You should probably wait because i'm resolving the merge conflicts and that might change things

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/structures/Message.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@bsian03 bsian03 merged commit a525c2e into bsian03:typings Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants