Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #13

Merged
merged 7 commits into from
Apr 1, 2015
Merged

Improvements #13

merged 7 commits into from
Apr 1, 2015

Conversation

robertrossmann
Copy link
Contributor

Added a bunch of improvements to the code. Some are just whitespace/formatting cleanup. The most important changes are:

  1. The public API is now truly async, meaning all callbacks will always be called in the next tick
  2. Added support for the kid header option (see here)

Please have a look and let me know if anything needs work. Thanks!

@robertrossmann
Copy link
Contributor Author

@bsphere, any feedback on this? Are you per chance interested in another maintainer for this module...?

bsphere added a commit that referenced this pull request Apr 1, 2015
@bsphere bsphere merged commit e6b4ce1 into bsphere:master Apr 1, 2015
@bsphere
Copy link
Owner

bsphere commented Apr 1, 2015

I'm interested in additional maintainers..

On Wed, 25 Feb 2015 at 20:19 Robert Rossmann notifications@github.com
wrote:

@bsphere https://github.com/bsphere, any feedback on this? Are you per
chance interested in another maintainer for this module...?


Reply to this email directly or view it on GitHub
#13 (comment).

@Mr0grog Mr0grog mentioned this pull request Apr 1, 2015
@bsphere bsphere mentioned this pull request Apr 2, 2015
@bsphere
Copy link
Owner

bsphere commented Apr 2, 2015

I reverted this PR, take a look at #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants