Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Xtend formatter settings #102

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Added Xtend formatter settings #102

merged 2 commits into from
Jun 19, 2018

Conversation

sigiesec
Copy link
Collaborator

@sigiesec sigiesec commented Jun 19, 2018

This change is Reviewable

@sigiesec sigiesec requested a review from a team June 19, 2018 13:26
blank.lines.between.methods=1
braces.in.new.line=true
eclipse.preferences.version=1
indentation=\t
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean using tabs for indentation? At the moment, all files are formatted using the "insert spaces for tabs" policy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.
I don't think that tabs should be used.

However, in the UI I cannot find any setting related to this. I will check that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there is an open issue related to this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=405956

Copy link
Collaborator Author

@sigiesec sigiesec Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.length=-1 in the line below also sounds strange

Maybe it is not possible to configure this via the UI, but the formatter still uses the setting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the impression they are ignored. The indentation settings can only be set for the workspace, and are taken from the Java Editor settings. Please set them to

  • Tab policy: Spaces only
  • Indentation size: 4

I will add this information to the contribution guidelines.

@sigiesec sigiesec merged commit d3963fc into master Jun 19, 2018
@sigiesec sigiesec deleted the add-formatter-config branch June 19, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants