-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Xtend formatter settings #102
Conversation
blank.lines.between.methods=1 | ||
braces.in.new.line=true | ||
eclipse.preferences.version=1 | ||
indentation=\t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean using tabs for indentation? At the moment, all files are formatted using the "insert spaces for tabs" policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
I don't think that tabs should be used.
However, in the UI I cannot find any setting related to this. I will check that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, there is an open issue related to this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=405956
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation.length=-1
in the line below also sounds strange
Maybe it is not possible to configure this via the UI, but the formatter still uses the setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the impression they are ignored. The indentation settings can only be set for the workspace, and are taken from the Java Editor settings. Please set them to
- Tab policy: Spaces only
- Indentation size: 4
I will add this information to the contribution guidelines.
This change is