Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump Spark Wallet" #462

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Revert "Bump Spark Wallet" #462

merged 1 commit into from
Apr 16, 2021

Conversation

Kukks
Copy link
Member

@Kukks Kukks commented Apr 16, 2021

Reverts #448

After the updates the spark url from services gives a 502

docker logs -t -f generated_clightning_bitcoin_spark_1
2021-04-16T06:07:52.747873175Z nc: unix connect failed: Connection refused

@Kukks Kukks merged commit 4b6ae57 into master Apr 16, 2021
@Kukks
Copy link
Member Author

Kukks commented Apr 16, 2021

cc @shesek @NicolasDorier anything comes to mind with this?

@Kukks Kukks deleted the revert-448-spark-bump branch April 16, 2021 06:10
shesek added a commit to shesek/spark-wallet that referenced this pull request Jul 26, 2021
@shesek
docker: Detect network subdirectory by the presence of 'lightning-rpc'
6729f84 
This is less prune to misdetection compared to using the database file,
but also means that mounting the parent directory will not work if spark
is started before c-lightning is.

Because of this, the documentation was updated to instruct users to
mount the network subdirectory containing the RPC file directly, rather
than relying on the automatic detection mechanism (which is more
advisable anyway).

This appears to be the underlying cause for
btcpayserver/btcpayserver-docker#462,
due to BTCPay's unusual 'rpc-file' setting.
@shesek
Copy link
Contributor

shesek commented Jul 26, 2021 •
edited
Loading

Hi, sorry for taking long to get to this!

The issue appears to be caused by a mechanism I implemented to ease the migration to per-network subdirectories (introduced in c-lightning v0.8.0). If the directory mounted in /etc/lightning didn't have the lightningd.sqlite3 file but a subdirectory matching the name of the network does have it, it will use the subdirectory instead.

BTCPay's (somewhat unusual) configuration for c-lightning creates the lightning-rpc file in the main directory while the database file is in the subdirectory, which caused this detection mechanism to fail. I implemented a change in shesek/spark-wallet@6729f84 that makes spark work properly when /etc/lightning is the directory with the lightning-rpc file (and updated the docs to advise users to mount that way).

I tested with BTCPay and verified that this fixes the issue you were experiencing (using the development docker image shesek/spark-wallet:0.2-next-standalone).

I will soon make an official release with this (plus some other goodies) and send a PR to update to it.

@Kukks
Copy link
Member Author

Kukks commented Jul 26, 2021

Hi, sorry for taking long to get to this!

The issue appears to be caused by a mechanism I implemented to ease the migration to per-network subdirectories (introduced in c-lightning v0.8.0). If the directory mounted in /etc/lightning didn't have the lightningd.sqlite3 file but a subdirectory matching the name of the network does have it, it will use the subdirectory instead.

BTCPay's (somewhat unusual) configuration for c-lightning creates the lightning-rpc file in the main directory while the database file is in the subdirectory, which caused this detection mechanism to fail. I implemented a change in shesek/spark-wallet@6729f84 that makes spark work properly when /etc/lightning is the directory with the lightning-rpc file (and updated the docs to advise users to mount that way).

I tested with BTCPay and verified that this fixes the issue you were experiencing (using the development docker image shesek/spark-wallet:0.2-next-standalone).

I will soon make an official release with this (plus some other goodies) and send a PR to update to it.

Thanks @shesek :)

@ampon0001

This comment was marked as spam.

Sign in to view
@ampon0001

This comment was marked as spam.

Sign in to view
@ampon0001

This comment was marked as spam.

Sign in to view
shesek added a commit to shesek/spark-wallet that referenced this pull request Sep 28, 2021
@shesek
docker: Detect network subdirectory by the presence of 'lightning-rpc'
498ea5d 
This is less prune to misdetection compared to using the database file,
but also means that mounting the parent directory will not work if spark
is started before c-lightning is.

Because of this, the documentation was updated to instruct users to
mount the network subdirectory containing the RPC file directly, rather
than relying on the automatic detection mechanism (which is more
advisable anyway).

This appears to be the underlying cause for
btcpayserver/btcpayserver-docker#462,
due to BTCPay's unusual 'rpc-file' setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kukks @shesek @ampon0001