Store branding: Add complementing text and accent colors #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use the current theme text color, independent of the brand color: This is problematic with rather light or dark branding colors, because we might show light text on a light background. This fixes that circumstance by calculating the complementing text color and also adds a slight adjustment for the hover/focus states. The accent color is calculated by decreasing the brightness a bit, which works for light and dark brand colors.
dennisreimann
added
Enhancement
|
it should probably be rather a non static method inside the color palette, but that's not really important. Good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the current theme text color, independent of the brand color: This is problematic with rather light or dark branding colors, because we might show light text on a light background. This fixes that circumstance by calculating the complementing text color and also adds a slight adjustment for the hover/focus states. The accent color is calculated by decreasing the brightness a bit, which works for light and dark brand colors.
Before
After